Repository navigation
fix(nav3): [Part 4] Preserve events with non-finite arguments - #6700
Draft
0xadam-brown wants to merge 2 commits into
Draft
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit Main concerns: data sent to Sentry, host performance, reach. This label is a hint for reviewers, not an approval. |
5 of 9 tasks
📲 Install BuildsAndroid
|
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
Sentry now records non-finite navigation argument values as the strings
"NaN","Infinity", and"-Infinity". This preserves their diagnostic meaning in a form that JSON can represent, and their text counts toward the existing argument budget so the fallback does not bypass payload limits.💡 Motivation and Context
Navigation arguments can legitimately contain
NaNor an infinite number, but JSON cannot represent those values as numbers. Passing them through unchanged can therefore prevent the event carrying the navigation data from being serialized, turning one unusual argument into the loss of an otherwise useful event.addresses: JAVA-787 (link)
💚 How did you test it?
Nav3 release build and all 446 unit tests passed. Repository-wide
make format api, Spotless checks, ABI validation, and Detekt passed.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 5: Reject ambiguous argument map keys.